Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otelgin): Support metrics for otelgin #6245

Closed
wants to merge 7 commits into from
Closed

feat(otelgin): Support metrics for otelgin #6245

wants to merge 7 commits into from

Conversation

gunturaf
Copy link
Contributor

This MR addresses #5096

@gunturaf gunturaf requested a review from a team as a code owner October 14, 2024 05:30
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.85714% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.5%. Comparing base (c3c8538) to head (5d2281c).

Files with missing lines Patch % Lines
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 71.2% 13 Missing and 6 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6245   +/-   ##
=====================================
  Coverage   66.5%   66.5%           
=====================================
  Files        188     188           
  Lines      12456   12524   +68     
=====================================
+ Hits        8284    8337   +53     
- Misses      3879    3889   +10     
- Partials     293     298    +5
Files with missing lines Coverage Δ
...ntation/github.com/gin-gonic/gin/otelgin/option.go 100.0% <100.0%> (ø)
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 76.6% <71.2%> (-5.6%) ⬇️

... and 1 file with indirect coverage changes

@pellared pellared closed this Oct 14, 2024
@pellared pellared reopened this Oct 14, 2024
pellared
pellared requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your interest in the project.

This module has no code owners and is deprecated thus we are not accepting PRs until code owners are found:

@gunturaf gunturaf changed the title feat(#5096): Support metrics for otelgin feat(!5096): Support metrics for otelgin Oct 14, 2024
@gunturaf gunturaf changed the title feat(!5096): Support metrics for otelgin feat(otelgin): Support metrics for otelgin Oct 14, 2024
@gunturaf
Copy link
Contributor Author

Thank you for your interest in the project.

This module has no code owners and is deprecated thus we are not accepting PRs until code owners are found:

* [Deprecate and remove go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin #6190](https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6190)

Aw snap... I failed to read that before I jump into the code!

@gunturaf gunturaf closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunturaf @pellared